[webkit-reviews] review granted: [Bug 198253] [JSC] ResultType implementation is wrong for bit ops, and ends up making ArithDiv in DFG Int32 fast path even if Baseline constantly produces Double result : [Attachment 378452] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted  review:
Bug 198253: [JSC] ResultType implementation is wrong for bit ops, and ends up
making ArithDiv in DFG Int32 fast path even if Baseline constantly produces
Double result
https://bugs.webkit.org/show_bug.cgi?id=198253

Attachment 378452: Patch

https://bugs.webkit.org/attachment.cgi?id=378452&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 378452
  --> https://bugs.webkit.org/attachment.cgi?id=378452
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378452&action=review

r=me

> Source/JavaScriptCore/parser/ResultType.h:151
> +	       return ResultType(TypeMaybeBigInt | TypeInt32 |
TypeMaybeNumber);

Should we remove the TypeInt32 since it's not needed, and it's suggesting the
wrong idea here?