[webkit-reviews] review requested: [Bug 200787] run-webkit-test: Allow results to be uploaded without scm checkout : [Attachment 378481] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 10 13:39:37 PDT 2019


Matt Lewis <jlewis3 at apple.com> has asked  for review:
Bug 200787: run-webkit-test: Allow results to be uploaded without scm checkout
https://bugs.webkit.org/show_bug.cgi?id=200787

Attachment 378481: Patch

https://bugs.webkit.org/attachment.cgi?id=378481&action=review




--- Comment #27 from Matt Lewis <jlewis3 at apple.com> ---
Created attachment 378481

  --> https://bugs.webkit.org/attachment.cgi?id=378481&action=review

Patch

I've tested the change a bit more and found that we were hitting an loop in the
find_checkout_root function that was being triggered due to being passed a path
that is 1 level higher than the checkout and never bailing when hitting the
root directory.


More information about the webkit-reviews mailing list