[webkit-reviews] review granted: [Bug 201631] [JSC] Manually adding 256 size class to make the current JSC allocation behavior stable : [Attachment 378443] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 201631: [JSC] Manually adding 256 size class to make the current JSC
allocation behavior stable
https://bugs.webkit.org/show_bug.cgi?id=201631

Attachment 378443: Patch

https://bugs.webkit.org/attachment.cgi?id=378443&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 378443
  --> https://bugs.webkit.org/attachment.cgi?id=378443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378443&action=review

r=me

> Source/JavaScriptCore/ChangeLog:38
> +	   This patch explicitly adds 256 into the size-class to make the
size-class sequence the thing we know it works well.

I suggest /know it works well/know works well/.

> Source/JavaScriptCore/heap/MarkedSpace.cpp:139
> +	       // Manually adding 256 case, empiricailly know this produces
good sequence of size classes.

I suggest rephrasing slightly: "Manually adding 256 case. We know empirically
that this produces efficient memory usage of size classes."