[webkit-reviews] review granted: [Bug 201596] Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html : [Attachment 378343] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted  review:
Bug 201596: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in
http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
https://bugs.webkit.org/show_bug.cgi?id=201596

Attachment 378343: Patch

https://bugs.webkit.org/attachment.cgi?id=378343&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 378343
  --> https://bugs.webkit.org/attachment.cgi?id=378343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378343&action=review

> Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:-58
> -	   RELEASE_ASSERT_WITH_MESSAGE(sessionID.isEphemeral() || sessionID ==
PAL::SessionID::defaultSessionID(), "If WebsitePolicies specifies a
WebsiteDataStore, the data store's session must be default or
non-persistent.");

Please remove the corresponding check in the ObjC API.	It's also no longer
needed.

> Tools/DumpRenderTree/TestRunner.cpp:2567
> +    ASSERT(!(m_shouldSwapToEphemeralSessionOnNextNavigation &&
m_shouldSwapToDefaultSessionOnNextNavigation));

ditto with comment below.

> Tools/WebKitTestRunner/TestController.cpp:2822
> +		   ASSERT(!(shouldSwapToEphemeralSessionOnNextNavigation &&
shouldSwapToDefaultSessionOnNextNavigation));

You could just assert that they are unequal.

> Tools/WebKitTestRunner/TestController.cpp:2824
> +		   WKRetainPtr<WKWebsiteDataStoreRef> newSession =
TestController::websiteDataStore();

There's no need to retain this.  Just use a plain old WKWebsiteDataStoreRef