[webkit-reviews] review granted: [Bug 197305] [Air] highOrderAdjacents in AbstractColoringAllocator::conservativeHeuristic should be some kind of array : [Attachment 368998] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 197305: [Air] highOrderAdjacents in
AbstractColoringAllocator::conservativeHeuristic should be some kind of array
https://bugs.webkit.org/show_bug.cgi?id=197305

Attachment 368998: Patch

https://bugs.webkit.org/attachment.cgi?id=368998&action=review




--- Comment #7 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 368998
  --> https://bugs.webkit.org/attachment.cgi?id=368998
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368998&action=review

r=me

> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:195
> +	   Vector<IndexType, 100> highOrderAdjacents;

Why not just make this MacroAssembler::numGPRs + MacroAssembler::numFPRs?
Alternatively you could make registerCount() constexpr.