[webkit-reviews] review granted: [Bug 201377] Add support to RTCDataChannel.send(Blob) : [Attachment 378052] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 08:49:28 PDT 2019


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 201377: Add support to RTCDataChannel.send(Blob)
https://bugs.webkit.org/show_bug.cgi?id=201377

Attachment 378052: Patch

https://bugs.webkit.org/attachment.cgi?id=378052&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 378052
  --> https://bugs.webkit.org/attachment.cgi?id=378052
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378052&action=review

> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:87
> +    , m_messageQueue(createMessageQueue(downcast<Document>(context), *this))

Can the constructor be updated to take a Document& instead of having an
unsafe-looking downcast here?


More information about the webkit-reviews mailing list