[webkit-reviews] review granted: [Bug 197492] [GTK][WPE] Remove attributes deprecated from MathML3 : [Attachment 378362] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 04:07:23 PDT 2019


Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 197492: [GTK][WPE] Remove attributes deprecated from MathML3
https://bugs.webkit.org/show_bug.cgi?id=197492

Attachment 378362: Patch

https://bugs.webkit.org/attachment.cgi?id=378362&action=review




--- Comment #5 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 378362
  --> https://bugs.webkit.org/attachment.cgi?id=378362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378362&action=review

> Source/WebCore/ChangeLog:11
> +	   This chaneg also maps the dir attribute to direction for MathML
Core.

typo: change ; for all MathML elements.

> Source/WebCore/mathml/MathMLElement.cpp:146
> +    } else {

As I said in private, I'm not really a fan of all these nested if else and
addPropertyToPresentationAttributeStyle calls. SVGElement does thing better.
But anyway, this is a separate issue that can be handled later.

>
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/attrib
ute-mapping-001.html:1
> +<!DOCTYPE html><!-- webkit-test-runner [ experimental:CoreMathMLEnabled=true
] -->

It's a pity we have to modified upstream WPT tests, but that's how WebKit does
it currently. For the record, I believe Mozilla and Chromium have separate
per-test or per-directory configuration files to enable experimental features.


More information about the webkit-reviews mailing list