[webkit-reviews] review granted: [Bug 201573] Disable TLS 1.0 and 1.1 in WebSockets : [Attachment 378293] fix windows build

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 201573: Disable TLS 1.0 and 1.1 in WebSockets
https://bugs.webkit.org/show_bug.cgi?id=201573

Attachment 378293: fix windows build

https://bugs.webkit.org/attachment.cgi?id=378293&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 378293
  --> https://bugs.webkit.org/attachment.cgi?id=378293
fix windows build

View in context: https://bugs.webkit.org/attachment.cgi?id=378293&action=review

> Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:314
> +void SocketStreamHandleImpl::setLegacyTLSEnabledCheck(Function<bool()>&&
function)

Can we just have setLegacyTLSEnabledCheck take a bool?

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:75
> +    });

We coud write it as
WebCore::SocketStreamHandleImpl::setLegacyTLSEnabledCheck(parameters.enableLega
cyTLS)

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:285
> +   
parameters.defaultDataStoreParameters.networkSessionParameters.enableLegacyTLS
= parameters.enableLegacyTLS;

We disable it for WebKit2.
Can we also do the same for WebKit1?