[webkit-reviews] review granted: [Bug 201590] Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html : [Attachment 378328] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 201590: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in
http/tests/workers/service/basic-register.html
https://bugs.webkit.org/show_bug.cgi?id=201590

Attachment 378328: Patch

https://bugs.webkit.org/attachment.cgi?id=378328&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 378328
  --> https://bugs.webkit.org/attachment.cgi?id=378328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378328&action=review

> Tools/ChangeLog:8
> +	   Add a new API test to check that if the default session registers a
service workers, the

s/workers/worker/

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1508
> +    configuration.get().websiteDataStore = [WKWebsiteDataStore
nonPersistentDataStore];

We were using an ephemeral session in the layout test because that was all we
had.
This test could be written with a non ephemeral session.