[webkit-reviews] review denied: [Bug 201543] [macOS] Pid is sometimes invalid when creating sandbox extensions by pid. : [Attachment 378338] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied	review:
Bug 201543: [macOS] Pid is sometimes invalid when creating sandbox extensions
by pid.
https://bugs.webkit.org/show_bug.cgi?id=201543

Attachment 378338: Patch

https://bugs.webkit.org/attachment.cgi?id=378338&action=review




--- Comment #21 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 378338
  --> https://bugs.webkit.org/attachment.cgi?id=378338
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378338&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1201
> +#if HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_PID)
> +    if (process->processIdentifier() || !url.isLocalFile())
> +	   process->send(Messages::WebPage::LoadRequest(loadParameters),
webPageID);
> +    else {
> +	   DelayedFileLoadRequest request { WTFMove(loadParameters), url,
m_pageLoadState.resourceDirectoryURL(), webPageID, process.get(), *this };
> +	   delayedFileLoadRequests().append(WTFMove(request));
> +    }
> +#else
>      process->send(Messages::WebPage::LoadRequest(loadParameters),
webPageID);
> +#endif

It seems like this will cause loads to be issued out of order. Consider the
case of the a local file load, which get's delayed, followed by a normal
non-local file load, which is done right away.