[webkit-reviews] review granted: [Bug 195765] Please add API to save a PDF from the contents of a WKWebView : [Attachment 378331] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 195765: Please add API to save a PDF from the contents of a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=195765

Attachment 378331: Patch

https://bugs.webkit.org/attachment.cgi?id=378331&action=review




--- Comment #17 from Tim Horton <thorton at apple.com> ---
Comment on attachment 378331
  --> https://bugs.webkit.org/attachment.cgi?id=378331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378331&action=review

Plus the one offline comment

> Source/WebCore/rendering/PaintPhase.h:70
> +    AnnotateLinks		   = 1 << 12,

This one is weird enough it probably deserves a comment

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:-4216
> -		537CF84822EFD72000C6EBB3 /* Check .xcfilelists */ = {

Where did this go??

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:5048
> +				       
"$(SYSTEM_LIBRARY_DIR)/Frameworks/Quartz.framework/Versions/A/Frameworks",

Shouldn't this be in an xcconfig?