[webkit-reviews] review denied: [Bug 201543] [macOS] Pid is sometimes invalid when creating sandbox extensions by pid. : [Attachment 378192] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 201543: [macOS] Pid is sometimes invalid when creating sandbox extensions
by pid.
https://bugs.webkit.org/show_bug.cgi?id=201543

Attachment 378192: Patch

https://bugs.webkit.org/attachment.cgi?id=378192&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 378192
  --> https://bugs.webkit.org/attachment.cgi?id=378192
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378192&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1074
> +	   if (!processIdentifier())
> +	       m_process->waitForProcessToFinishLaunching();

It seems like this is introducing a synchronous wait in the UIProcess on the
main thread. This is a huge no-no. This should be avoided at all costs. 

If you really need the pid for this, the code needs to be restructured so that
the work items that need it are queued, and then completed when the pid is
available.