[webkit-reviews] review granted: [Bug 201419] Use WebProcess processIdentifier to identify IDB connections between WebProcess and NetworkProcess : [Attachment 377881] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 201419: Use WebProcess processIdentifier to identify IDB connections
between WebProcess and NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=201419

Attachment 377881: Patch

https://bugs.webkit.org/attachment.cgi?id=377881&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 377881
  --> https://bugs.webkit.org/attachment.cgi?id=377881
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377881&action=review

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:64
> +    uint64_t identifier() const final { return m_identifier.toUInt64(); }

We should eventually make this a strongly-typed identifier.

> Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:58
> +    uint64_t messageSenderDestinationID() const final { return
m_sessionID.toUInt64(); }

We should eventually make this a strongly-typed identifier.