[webkit-reviews] review granted: [Bug 201402] REGRESSION (r249367): m_decodingPromises grows indefinitely until ImageLoader destruction : [Attachment 378089] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 201402: REGRESSION (r249367): m_decodingPromises grows indefinitely until
ImageLoader destruction
https://bugs.webkit.org/show_bug.cgi?id=201402

Attachment 378089: Patch

https://bugs.webkit.org/attachment.cgi?id=378089&action=review




--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 378089
  --> https://bugs.webkit.org/attachment.cgi?id=378089
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378089&action=review

> Source/WebCore/loader/ImageLoader.cpp:294
> +    resolvePromises(WTFMove(m_decodingPromises));

It seems simpler to just inline resolvePromises here.
If you want to keep the move promises before iterating over, it can be written
as:

ASSERT(!m_decodingPromises.isEmpty());
auto promises = WTFMove(m_decodingPromises);
for (auto& promise : promises)
    promise->....