[webkit-reviews] review granted: [Bug 201480] When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID : [Attachment 378138] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 6 02:41:25 PDT 2019


youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 201480: When disabling legacy private browsing for testing, change the
SessionID back to what it was, not the defaultSessionID
https://bugs.webkit.org/show_bug.cgi?id=201480

Attachment 378138: Patch

https://bugs.webkit.org/attachment.cgi?id=378138&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 378138
  --> https://bugs.webkit.org/attachment.cgi?id=378138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378138&action=review

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:357
> +    if (enabled) {

Might be clearer to have one big if(enabled) instead of several enabled checks.


More information about the webkit-reviews mailing list