[webkit-reviews] review granted: [Bug 201537] [GStreamer] YUV buffers on iMX platforms have to be treated as RGBA : [Attachment 378166] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 6 01:37:59 PDT 2019


Philippe Normand <pnormand at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 201537: [GStreamer] YUV buffers on iMX platforms have to be treated as RGBA
https://bugs.webkit.org/show_bug.cgi?id=201537

Attachment 378166: Patch

https://bugs.webkit.org/attachment.cgi?id=378166&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 378166
  --> https://bugs.webkit.org/attachment.cgi?id=378166
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378166&action=review

Looks good, I'll give it a test run on my board, please hold on :)

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2432
> +	   else if (g_str_has_prefix(elementName.get(), "imxvpudecoder"))

Can you make the prefix a bit shorter? It would alloww to cover the gst-imx v2
branch if "imxvpudec" is used.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
237
> +		   fprintf(stderr, "\tYUV but weird\n");

:)


More information about the webkit-reviews mailing list