[webkit-reviews] review denied: [Bug 201534] PathDirect2D Cleanups : [Attachment 378159] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 201534: PathDirect2D Cleanups
https://bugs.webkit.org/show_bug.cgi?id=201534

Attachment 378159: Patch

https://bugs.webkit.org/attachment.cgi?id=378159&action=review




--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 378159
  --> https://bugs.webkit.org/attachment.cgi?id=378159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378159&action=review

> Source/WebCore/platform/graphics/Path.h:199
>	   void drawDidComplete();

Path::drawDidComplete is not used anywhere in WebKit. It should be removed.

> Source/WebCore/platform/graphics/Path.h:215
>	   COMPtr<ID2D1PathGeometry> m_activePathGeometry;

m_activePathGeometry is not needed because it is stored in m_geometries and the
active path sync is stored in m_activePath.

> Source/WebCore/platform/graphics/win/Direct2DOperations.cpp:498
> +    const_cast<Path&>(path).closeAnyOpenGeometries(D2D1_FIGURE_END_OPEN);

Can you remove `const_cast` by making closeAnyOpenGeometries a mutable method?

> Source/WebCore/platform/graphics/win/PathDirect2D.cpp:118
> +    HRESULT hr =
GraphicsContext::systemFactory()->CreateGeometryGroup(fillMode,
m_geometries.data(), m_geometries.size(), &m_path);

Path::appendGeometry always create a GeometryGroup by calling
CreateGeometryGroup.
Can it be done in Path::closeAnyOpenGeometries?

> Source/WebCore/platform/graphics/win/PathDirect2D.cpp:311
> +	   while (m_openFigureCount) {

m_openFigureCount can be 1 or 0. m_openFigureCount can be bool
m_isFigureOpened.