[webkit-reviews] review granted: [Bug 201519] Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing : [Attachment 378127] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 201519: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in
imported/w3c/IndexedDB-private-browsing
https://bugs.webkit.org/show_bug.cgi?id=201519

Attachment 378127: Patch

https://bugs.webkit.org/attachment.cgi?id=378127&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 378127
  --> https://bugs.webkit.org/attachment.cgi?id=378127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378127&action=review

> Tools/WebKitTestRunner/TestOptions.cpp:61
> +    return pathContains(pathOrURL, "w3c/IndexedDB-private-browsing") ||
pathContains(pathOrURL, "w3c\\IndexedDB-private-browsing");

Maybe pathContains should be made to replace '\\' with '/' before doing the
comparison so we don't need both of these for all call sites.