[webkit-reviews] review granted: [Bug 201514] Web Inspector: Crashes when intercept response is a 404 : [Attachment 378117] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 5 16:48:07 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 201514: Web Inspector: Crashes when intercept response is a 404
https://bugs.webkit.org/show_bug.cgi?id=201514

Attachment 378117: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=378117&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 378117
  --> https://bugs.webkit.org/attachment.cgi?id=378117
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378117&action=review

> Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:147
> +	   Ref<WebResourceLoader> interceptProtectedThis(*this);

Please just call it protectedThis, and do it in the lambda capture:
protectedThis = makeRef(*this)


More information about the webkit-reviews mailing list