[webkit-reviews] review granted: [Bug 201521] Refactor the Gigacage code to require less pointer casting. : [Attachment 378129] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 201521: Refactor the Gigacage code to require less pointer casting.
https://bugs.webkit.org/show_bug.cgi?id=201521

Attachment 378129: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=378129&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 378129
  --> https://bugs.webkit.org/attachment.cgi?id=378129
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=378129&action=review

r=me

> Source/bmalloc/ChangeLog:17
> +	   5. Change LLInt's loadCagedJSValue() to skip the caging if Gigacage
is not enabled
> +	      in the build.  This allows us to remove the unneeded stubs in WTF
Gigacage.h.

nit: some part of this belongs in the JSC changelog.

> Source/bmalloc/bmalloc/Gigacage.h:50
> +    NumberOfKinds // This should always be at the end of this list.

this comment is implied by the name of the enum value

> Source/bmalloc/bmalloc/Gigacage.h:61
> +	   break; // Invalid: go to BCRASH();

no need for this comment