[webkit-reviews] review granted: [Bug 201513] [JSC] Generalize Get/PutPromiseInternalField for InternalFieldObjectImpl : [Attachment 378116] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 201513: [JSC] Generalize Get/PutPromiseInternalField for
InternalFieldObjectImpl
https://bugs.webkit.org/show_bug.cgi?id=201513

Attachment 378116: Patch

https://bugs.webkit.org/attachment.cgi?id=378116&action=review




--- Comment #7 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 378116
  --> https://bugs.webkit.org/attachment.cgi?id=378116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378116&action=review

Looks nice and simple to me.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:168
> +const JSInternalFieldObjectImpl_internalFields =
JSInternalFieldObjectImpl::m_internalFields

Is this constant just a stylistic matter? Just curious since we weren't using
one before.