[webkit-reviews] review granted: [Bug 201495] [JSC] Do not use FTLOutput::weakPointer directly : [Attachment 378051] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 5 08:08:15 PDT 2019
Filip Pizlo <fpizlo at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 201495: [JSC] Do not use FTLOutput::weakPointer directly
https://bugs.webkit.org/show_bug.cgi?id=201495
Attachment 378051: Patch
https://bugs.webkit.org/attachment.cgi?id=378051&action=review
--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 378051
--> https://bugs.webkit.org/attachment.cgi?id=378051
Patch
Can you do a follow-up that renames FTL::Output::weakPointer so that folks
don't make the same mistake? Maybe Output::alreadyRegisteredWeakPointer or
something that makes it clear what the assumptions are.
More information about the webkit-reviews
mailing list