[webkit-reviews] review granted: [Bug 201486] [GTK][WPE] Do not enable the sandbox in Snap : [Attachment 378039] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 5 01:32:59 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 201486: [GTK][WPE] Do not enable the sandbox in Snap
https://bugs.webkit.org/show_bug.cgi?id=201486

Attachment 378039: Patch

https://bugs.webkit.org/attachment.cgi?id=378039&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 378039
  --> https://bugs.webkit.org/attachment.cgi?id=378039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378039&action=review

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:65
> +    static int ret = -1;

Use Optional<bool> instead.

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:69
> +    ret = g_getenv("SNAP") != nullptr;

Do not compare to nullptr.


More information about the webkit-reviews mailing list