[webkit-reviews] review granted: [Bug 201484] LazyClassStructure::setConstructor should not store the constructor to the global object : [Attachment 378035] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 201484: LazyClassStructure::setConstructor should not store the constructor
to the global object
https://bugs.webkit.org/show_bug.cgi?id=201484

Attachment 378035: Patch

https://bugs.webkit.org/attachment.cgi?id=378035&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 378035
  --> https://bugs.webkit.org/attachment.cgi?id=378035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378035&action=review

r=me with comment.

> Source/JavaScriptCore/runtime/Lookup.h:367
> +	   if (!propertyName.isNull())

I think this never happens because this function is called for property
materialization.
I think `propertyName.isNull()` code in the original one exists for the use
case not through static-property-table. And I believe we do not have a case
like,

1. While using LazyClassStructure without specifying it in
static-property-table...
2. But still we want global object property for that.

Can you ensure that the above use case does not exist in our code base?