[webkit-reviews] review granted: [Bug 201311] run-api-tests: Add support for specifying additional environment variables : [Attachment 377986] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 201311: run-api-tests: Add support for specifying additional environment
variables
https://bugs.webkit.org/show_bug.cgi?id=201311

Attachment 377986: Patch

https://bugs.webkit.org/attachment.cgi?id=377986&action=review




--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 377986
  --> https://bugs.webkit.org/attachment.cgi?id=377986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377986&action=review

> Tools/Scripts/webkitpy/port/base.py:275
> +	   for key in ['DYLD_LIBRARY_PATH', '__XPC_DYLD_LIBRARY_PATH',
'DYLD_FRAMEWORK_PATH', '__XPC_DYLD_FRAMEWORK_PATH']:
> +	       if environment.get(key):
> +		   environment[key] = environment[key] + os.pathsep +
build_root_path
> +	       else:
> +		   environment[key] = build_root_path

Good use of os.pathsep. Can self._append_value_colon_separated() be used here
instead of duplicating its functionality? If not, please explain in the
ChangeLog why it cannot be used. For this patch or a future patch
append_value_colon_separated() could benefit by writing in terms of os.pathsep.