[webkit-reviews] review granted: [Bug 200470] Implement MathML DOM : [Attachment 377991] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 200470: Implement MathML DOM
https://bugs.webkit.org/show_bug.cgi?id=200470

Attachment 377991: Patch

https://bugs.webkit.org/attachment.cgi?id=377991&action=review




--- Comment #21 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 377991
  --> https://bugs.webkit.org/attachment.cgi?id=377991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377991&action=review

> LayoutTests/mathml/focus-event-handling.html:22
> +<script src="focus-event-handling.js"></script>

Please inline the script here. Having a separate JS file is an old style we
don't want to use in new tests.

> LayoutTests/mathml/focus-event-handling.js:46
> +    eventSender.mouseMoveTo(x, y);
> +    eventSender.mouseDown();
> +    eventSender.mouseUp();

Please use ui-helper.js and UIHelper.activateAt or UIHelper.activateElement
so that this test would run in iOS WebKit2.