[webkit-reviews] review granted: [Bug 201330] On the first compositing update, "drawsContent" can be wrong : [Attachment 377955] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 201330: On the first compositing update, "drawsContent" can be wrong
https://bugs.webkit.org/show_bug.cgi?id=201330

Attachment 377955: Patch

https://bugs.webkit.org/attachment.cgi?id=377955&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 377955
  --> https://bugs.webkit.org/attachment.cgi?id=377955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377955&action=review

> Source/WebCore/rendering/RenderLayerBacking.h:87
> +    void updateGeometry(const RenderLayer* compositingAncestor, const
RenderLayer* compositedAncestorWithBackingStore);

Can we start passing the traversal state like I suggested before?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1238
> +	       layerBacking->updateGeometry(traversalState.compositingAncestor,
traversalStateForDescendants.paintDestinationAncestor);

It seems wrong this is consulting traversalStateForDescendants while calling
into backing of the current layer.