[webkit-reviews] review denied: [Bug 201445] [Win] Add support for MouseEvent.buttons : [Attachment 377954] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 201445: [Win] Add support for MouseEvent.buttons
https://bugs.webkit.org/show_bug.cgi?id=201445

Attachment 377954: Patch

https://bugs.webkit.org/attachment.cgi?id=377954&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 377954
  --> https://bugs.webkit.org/attachment.cgi?id=377954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377954&action=review

> Source/WebCore/platform/win/PlatformMouseEventWin.cpp:121
> +	       m_button = NoButton;

This change seems to break AppleWin (editing and drag/drop operations). Do
those tests need to be rebased? Is WebKit relying on behavior that is counter
to the spec?

The tests that are failing related to editing/selection and dragging. I know
that dragging involves mouse moves with the left button held down; I suspect
this change breaks those tests because MouseMove (after this change) always has
NoButton.

I don't think this change is correct.