[webkit-reviews] review granted: [Bug 201449] Structure::storedPrototype() and storedPrototypeObject() should assert with isCompilationThread(), not !isMainThread(). : [Attachment 377959] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 201449: Structure::storedPrototype() and storedPrototypeObject() should
assert with isCompilationThread(), not !isMainThread().
https://bugs.webkit.org/show_bug.cgi?id=201449

Attachment 377959: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=377959&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 377959
  --> https://bugs.webkit.org/attachment.cgi?id=377959
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=377959&action=review

r=me

> Source/JavaScriptCore/runtime/StructureInlines.h:111
> +    ASSERT(isCompilationThread() || object->structure() == this);

Is it possible that the GC thread accesses to this functions? If so, we should
allow GC thread too (I think we have an check like isCompilationThread). If
not, this check is fine.

> Source/JavaScriptCore/runtime/StructureInlines.h:119
> +    ASSERT(isCompilationThread() || object->structure() == this);

Ditto.