[webkit-reviews] review granted: [Bug 201444] [macOS] Unable to open local file from favorites bar : [Attachment 377951] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 20:26:40 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 201444: [macOS] Unable to open local file from favorites bar
https://bugs.webkit.org/show_bug.cgi?id=201444

Attachment 377951: Patch

https://bugs.webkit.org/attachment.cgi?id=377951&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 377951
  --> https://bugs.webkit.org/attachment.cgi?id=377951
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377951&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:1068
> +	   if
(SandboxExtension::createHandleForReadByPid(resourceDirectoryURL.fileSystemPath
(), process.processIdentifier(), sandboxExtensionHandle)) {

Yikes! How did we miss this path?


More information about the webkit-reviews mailing list