[webkit-reviews] review granted: [Bug 201299] Move MessageRegistry to NetworkProcess : [Attachment 377853] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 14:23:28 PDT 2019


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 201299: Move MessageRegistry to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=201299

Attachment 377853: Patch

https://bugs.webkit.org/attachment.cgi?id=377853&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 377853
  --> https://bugs.webkit.org/attachment.cgi?id=377853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377853&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:962
> +void NetworkConnectionToWebProcess::checkRemotePortForActivity(const
WebCore::MessagePortIdentifier port, CompletionHandler<void(bool)>&& callback)

It would make things a bit cleaner to make this
CompletionHandler<void(HasActivity)>

> Source/WebKit/NetworkProcess/NetworkMessagePortChannelProvider.cpp:68
> +    // Should never be called in the UI process provider.
> +    ASSERT_NOT_REACHED();

Can we remove all these?
Could we at least write code that calls the CompletionHandlers?


More information about the webkit-reviews mailing list