[webkit-reviews] review granted: [Bug 201381] Make "clips compositing descendants" an indirect compositing reason : [Attachment 377854] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 11:13:01 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 201381: Make "clips compositing descendants" an indirect compositing reason
https://bugs.webkit.org/show_bug.cgi?id=201381

Attachment 377854: Patch

https://bugs.webkit.org/attachment.cgi?id=377854&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 377854
  --> https://bugs.webkit.org/attachment.cgi?id=377854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377854&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3069
> +    return IndirectCompositingReason::None;

Would be nice to modernise this to use Optional/OptionSet at some point.


More information about the webkit-reviews mailing list