[webkit-reviews] review granted: [Bug 201403] Cache "compositingAncestor" during the compositing updateBackingAndHierarchy() tree walk : [Attachment 377855] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 3 10:32:32 PDT 2019
Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 201403: Cache "compositingAncestor" during the compositing
updateBackingAndHierarchy() tree walk
https://bugs.webkit.org/show_bug.cgi?id=201403
Attachment 377855: Patch
https://bugs.webkit.org/attachment.cgi?id=377855&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 377855
--> https://bugs.webkit.org/attachment.cgi?id=377855
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=377855&action=review
> Source/WebCore/rendering/RenderLayerCompositor.h:519
> - OptionSet<ScrollCoordinationRole>
coordinatedScrollingRolesForLayer(const RenderLayer&) const;
> + OptionSet<ScrollCoordinationRole>
coordinatedScrollingRolesForLayer(const RenderLayer&, const RenderLayer*
compositingAncestor) const;
>
> // Returns the ScrollingNodeID which acts as the parent for children.
> - ScrollingNodeID updateScrollCoordinationForLayer(RenderLayer&, struct
ScrollingTreeState&, OptionSet<ScrollingNodeChangeFlags>);
> + ScrollingNodeID updateScrollCoordinationForLayer(RenderLayer&, const
RenderLayer* compositingAncestor, struct ScrollingTreeState&,
OptionSet<ScrollingNodeChangeFlags>);
It might be better to pass in UpdateBackingTraversalState& instead of
RenderLayer* to these functions. It makes clear in which context these
functions are used in and potentially allows caching more things in future.
More information about the webkit-reviews
mailing list