[webkit-reviews] review granted: [Bug 201415] [WPE] Make view backends multi-view-friendly : [Attachment 377871] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 201415: [WPE] Make view backends multi-view-friendly
https://bugs.webkit.org/show_bug.cgi?id=201415

Attachment 377871: Patch

https://bugs.webkit.org/attachment.cgi?id=377871&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 377871
  --> https://bugs.webkit.org/attachment.cgi?id=377871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377871&action=review

> Tools/ChangeLog:7
> +

Could you explain here why the changes make view backends multi-view-friendly?
Looking at the patch it seems just a refactoring to move the code to initialize
EGL.

> Tools/wpe/backends/HeadlessViewBackend.cpp:61
> +		   if (!eglInitialize(eglDisplay, nullptr, nullptr))

Don't we need to do the eglBindAPI here too?