[webkit-reviews] review canceled: [Bug 201339] [EME] Introduce a Proxy CDM for thread-safe access to CDM instances from background decryption threads : [Attachment 377700] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has canceled Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 201339: [EME] Introduce a Proxy CDM for thread-safe access to CDM instances
from background decryption threads
https://bugs.webkit.org/show_bug.cgi?id=201339

Attachment 377700: Patch

https://bugs.webkit.org/attachment.cgi?id=377700&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 377700
  --> https://bugs.webkit.org/attachment.cgi?id=377700
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377700&action=review

LGTM as a WIP patch.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1323
> +    GST_DEBUG_OBJECT(m_pipeline.get(), "CDM proxy instance %p dispatched as
context", m_cdmInstance->proxyCDM().get());

I'd say ProxyCDM instance...

>
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorG
Streamer.cpp:298
> +		   GST_DEBUG_OBJECT(self, "received a new CDM proxy instance
%p, refcount %u", priv->proxyCDM.get(), priv->proxyCDM->refCount());

ProxyCDM