[webkit-reviews] review granted: [Bug 201373] [JSC] Merge op_check_traps into op_enter and op_loop_hint : [Attachment 377816] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 201373: [JSC] Merge op_check_traps into op_enter and op_loop_hint
https://bugs.webkit.org/show_bug.cgi?id=201373

Attachment 377816: Patch

https://bugs.webkit.org/attachment.cgi?id=377816&action=review




--- Comment #17 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 377816
  --> https://bugs.webkit.org/attachment.cgi?id=377816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377816&action=review

Nice work.  r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:727
> +    callTrapHandler(.throwHandler)

Why not also callTrapHandler(_llint_throw_from_slow_path_trampoline) here like
you did in llintOp(op_loop_hint)?

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:730
> +.throwHandler:
> +    jmp _llint_throw_from_slow_path_trampoline

Not needed if you callTrapHandler(_llint_throw_from_slow_path_trampoline)
above.