[webkit-reviews] review granted: [Bug 203705] Disable Wasm interpreter on WinCairo : [Attachment 382524] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 203705: Disable Wasm interpreter on WinCairo
https://bugs.webkit.org/show_bug.cgi?id=203705

Attachment 382524: Patch

https://bugs.webkit.org/attachment.cgi?id=382524&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 382524
  --> https://bugs.webkit.org/attachment.cgi?id=382524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382524&action=review

r=me with FIXME request.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:2018
> +if WEBASSEMBLY and not X86_64_WIN

Can you add a FIXME and URL to fix this issue? I think this is essentially
unnecessary, and it should be fixed.
I don’t consider that WEBASSEMBLY is true on Windows, so it would eventually
can cause the problem again: like putting a code that is guarded by
WEBASSEMBLY, but we don’t consider Windows at all.
So I think this should be fixed soon, but I don’t want to Wasm interpreter
patch roll-out. So, I’m OK for this for very short-term workaround.