[webkit-reviews] review granted: [Bug 203680] Port ServiceWorkerContainer to the HTML5 event loop : [Attachment 382494] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 203680: Port ServiceWorkerContainer to the HTML5 event loop
https://bugs.webkit.org/show_bug.cgi?id=203680

Attachment 382494: Patch

https://bugs.webkit.org/attachment.cgi?id=382494&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 382494
  --> https://bugs.webkit.org/attachment.cgi?id=382494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382494&action=review

> Source/WebCore/workers/WorkerEventLoop.cpp:38
> +    auto eventLoop = adoptRef(*new WorkerEventLoop(context));
> +    eventLoop->suspendIfNeeded();
> +    return eventLoop;

Maybe we can just do this in the constructor?

> Source/WebCore/workers/WorkerEventLoop.cpp:45
> +    eventLoop->suspendIfNeeded();

Ditto.