[webkit-reviews] review granted: [Bug 203580] [EME] Batch multiple key requests into one request and response : [Attachment 382477] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 203580: [EME] Batch multiple key requests into one request and response
https://bugs.webkit.org/show_bug.cgi?id=203580

Attachment 382477: Patch

https://bugs.webkit.org/attachment.cgi?id=382477&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 382477
  --> https://bugs.webkit.org/attachment.cgi?id=382477
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382477&action=review

> Source/WebCore/ChangeLog:17
> +	     in m_currentRequset and m_requests, or in m_pendingRequests.

Nit: m_currentRequset => m_currentRequest

> Source/WebCore/ChangeLog:23
> +	   - There are a couple helper classes that facilitate collecting
delegate callbacks and completion handlers

Nit: are a couple helper => are a couple of helper

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreaming
AVFObjC.mm:536
> +	       // Either "payload" nor "error" are present, but not both

Nit: nor => or