[webkit-reviews] review granted: [Bug 203696] [JSC] Make String#localeCompare faster by inlining JSGlobalObject::defaultCollator : [Attachment 382497] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 31 14:00:48 PDT 2019


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 203696: [JSC] Make String#localeCompare faster by inlining
JSGlobalObject::defaultCollator
https://bugs.webkit.org/show_bug.cgi?id=203696

Attachment 382497: Patch

https://bugs.webkit.org/attachment.cgi?id=382497&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 382497
  --> https://bugs.webkit.org/attachment.cgi?id=382497
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382497&action=review

r=me with fix and if EWS bots are green.

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:903
> +	       scope.assertNoException();

Since you're expecting no exception, use DECLARE_CATCH_SCOPE instead of
DECLARE_THROW_SCOPE?  Might as well make this a releaseAssertNoException() too.


More information about the webkit-reviews mailing list