[webkit-reviews] review granted: [Bug 203668] Web Inspector: REGRESSION(r251038): Elements: Computed: variables are shown in the Properties section instead of in the Variables section : [Attachment 382439] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 203668: Web Inspector: REGRESSION(r251038): Elements: Computed: variables
are shown in the Properties section instead of in the Variables section
https://bugs.webkit.org/show_bug.cgi?id=203668

Attachment 382439: Patch

https://bugs.webkit.org/attachment.cgi?id=382439&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 382439
  --> https://bugs.webkit.org/attachment.cgi?id=382439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112
> +    set propertyVisibilityMode(propertyVisibilityMode)

This is kind of wordy. I think the context is clear, how about just naming the
parameter `mode`?