[webkit-reviews] review denied: [Bug 203594] Mark VeryLow priority requests using a request dictionary key : [Attachment 382261] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 31 11:51:34 PDT 2019
Alex Christensen <achristensen at apple.com> has denied Ben Nham
<nham at apple.com>'s request for review:
Bug 203594: Mark VeryLow priority requests using a request dictionary key
https://bugs.webkit.org/show_bug.cgi?id=203594
Attachment 382261: Patch
https://bugs.webkit.org/attachment.cgi?id=382261&action=review
--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 382261
--> https://bugs.webkit.org/attachment.cgi?id=382261
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=382261&action=review
> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:253
> +#define WKVeryLowLoadPriorityKey CFSTR("WKVeryLowLoadPriority")
This is not actually in CFNetwork. This should not be defined in
CFNetworkSPI.h.
> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:308
> +CFTypeRef _CFURLRequestCopyProtocolPropertyForKey(CFURLRequestRef,
CFStringRef);
This is unused.
More information about the webkit-reviews
mailing list