[webkit-reviews] review denied: [Bug 203623] Resource Load Statistics: Flush the shared ResourceLoadObserver when the webpage is closed by JavaScript : [Attachment 382385] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied John Wilander
<wilander at apple.com>'s request for review:
Bug 203623: Resource Load Statistics: Flush the shared ResourceLoadObserver
when the webpage is closed by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=203623

Attachment 382385: Patch

https://bugs.webkit.org/attachment.cgi?id=382385&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 382385
  --> https://bugs.webkit.org/attachment.cgi?id=382385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382385&action=review

> Source/WebCore/loader/ResourceLoadObserver.cpp:39
> +    delete sharedObserver();

Could we use a std::unique_ptr<ResourceLoadObserver> instead of manual
new/delete?

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:286
> +	   m_statisticsStore->updateCookieBlocking([this, protectedThis =
makeRef(*this)]() {

Grumble grumble.  https://twitter.com/alexfchr/status/1083136307197440000
Here, to work around a VS bug we need to do protectedThis =
protectedThis.copyRef()