[webkit-reviews] review canceled: [Bug 203672] [CMake] TestWebCore shouldn't link with WebCoreTestSupport : [Attachment 382446] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 31 05:00:36 PDT 2019


Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 203672: [CMake] TestWebCore shouldn't link with WebCoreTestSupport
https://bugs.webkit.org/show_bug.cgi?id=203672

Attachment 382446: Patch

https://bugs.webkit.org/attachment.cgi?id=382446&action=review




--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 382446
  --> https://bugs.webkit.org/attachment.cgi?id=382446
Patch

wincairo ews can't compile DumpRenderTreeLib.

> FAILED:
Tools/DumpRenderTree/CMakeFiles/DumpRenderTreeLib.dir/WorkQueue.cpp.obj 
> C:\MSVS\VC\Tools\MSVC\14.23.28105\bin\Hostx64\x64\cl.exe  /nologo /TP
-DBUILDING_WITH_CMAKE=1 -DDumpRenderTreeLib_EXPORTS -DHAVE_CONFIG_H=1 -DNOCRYPT
-DNOMINMAX -DUNICODE -DUSE_CONSOLE_ENTRY_POINT -DWINVER=0x601 -DWIN_CAIRO
-DWTF_PLATFORM_WIN_CAIRO=1 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1
-D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601
-D_WINDOWS -D_WINSOCKAPI_="" -IWebCore\PrivateHeaders -IWebKitLegacy\Headers
-IDerivedSources\DumpRenderTree -I..\..\Tools\TestRunnerShared\UIScriptContext
-I..\..\Tools\TestRunnerShared\Bindings -I..\..\Tools\DumpRenderTree
-I..\..\Source -I..\..\Source\WebCore\testing\js
-I..\..\Tools\DumpRenderTree\win
-I..\..\Tools\DumpRenderTree\TestNetscapePlugIn
-I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\ForwardingHeaders
-I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\Tests
-I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\win
-I..\..\Tools\DumpRenderTree\TestNetscapePlugIn\Tests\win
-I..\..\Tools\DumpRenderTree\cairo -I..\..\WebKitLibraries\win\include\cairo
-IJavaScriptCore\Headers -IJavaScriptCore\PrivateHeaders -IWTF\Headers -I.
-IDerivedSources -I..\..\Source\ThirdParty -I..\..\WebKitLibraries\win\include
/W4 /DWIN32 /D_WINDOWS	/GR- /EHs- /EHc-  /MD /O2 /Ob2 /DNDEBUG   /wd4018
/wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206
/wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355
/wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510
/wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819
/wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS
/EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /utf-8 /validate-charset /Oy-
-std:c++17 /Yu"DumpRenderTreePrefix.h" /FI"DumpRenderTreePrefix.h"
/Fp"C:/Buildbot/WinCairo-EWS/build/WebKitBuild/Release/Tools/DumpRenderTree/Dum
pRenderTreeLib_SOURCES/DumpRenderTreePrefix.pch" /showIncludes
/FoTools\DumpRenderTree\CMakeFiles\DumpRenderTreeLib.dir\WorkQueue.cpp.obj
/FdTools\DumpRenderTree\CMakeFiles\DumpRenderTreeLib.dir\ /FS -c
..\..\Tools\DumpRenderTree\WorkQueue.cpp
> C:\Buildbot\WinCairo-EWS\build\Tools\DumpRenderTree\config.h(27): fatal error
C1083: Cannot open include file: 'pal/ExportMacros.h': No such file or
directory


More information about the webkit-reviews mailing list