[webkit-reviews] review granted: [Bug 203654] Rename AccessibilityObject::matchedParent as Accessibility::findAncestor and re-implement in a generic way so that can be used with both AccessibilityObjects and AXIsolatedTreeNodes. : [Attachment 382408] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 203654: Rename AccessibilityObject::matchedParent as
Accessibility::findAncestor and re-implement in a generic way so that can be
used with both AccessibilityObjects and AXIsolatedTreeNodes.
https://bugs.webkit.org/show_bug.cgi?id=203654

Attachment 382408: Patch

https://bugs.webkit.org/attachment.cgi?id=382408&action=review




--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 382408
  --> https://bugs.webkit.org/attachment.cgi?id=382408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382408&action=review

approved pending fixes of minor nits

> Source/WebCore/ChangeLog:12
> +	   - Created the namespace Accessibility for implementation deatils
that not need to be exposed to client code.

deatils > details

> Source/WebCore/accessibility/AccessibilityObjectInterface.h:1103
> +} // namespace ax

// namespace Accessibility