[webkit-reviews] review granted: [Bug 203548] [FTW] Adopt DirectWrite in place of Uniscribe : [Attachment 382282] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 203548: [FTW] Adopt DirectWrite in place of Uniscribe
https://bugs.webkit.org/show_bug.cgi?id=203548

Attachment 382282: Patch

https://bugs.webkit.org/attachment.cgi?id=382282&action=review




--- Comment #32 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 382282
  --> https://bugs.webkit.org/attachment.cgi?id=382282
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382282&action=review

>>>
Source/WebCore/platform/graphics/win/ComplexTextControllerDirectWrite.cpp:175
>>> +	     m_complexTextRuns.append(ComplexTextRun::create(advances, origins,
glyphs, stringIndices, FloatSize(), *font, currentCP, 0, run.length, 0,
run.length, m_run.ltr()));
>> 
>> If you reuse Vectors, all ComplexTextRun shares same Vectors for advances,
origins, glyphs, stringIndices.
> 
> I believe the constructor for ComplextTextRun makes a copy of the vectors it
receives, so I think each will be distinct.

Ah. You are right. Sorry for the noise.