[webkit-reviews] review granted: [Bug 202601] [Cocoa] Right Command key should have location DOM_KEY_LOCATION_RIGHT instead of DOM_KEY_LOCATION_STANDARD : [Attachment 381555] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 202601: [Cocoa] Right Command key should have location
DOM_KEY_LOCATION_RIGHT instead of DOM_KEY_LOCATION_STANDARD
https://bugs.webkit.org/show_bug.cgi?id=202601

Attachment 381555: Patch

https://bugs.webkit.org/attachment.cgi?id=381555&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 381555
  --> https://bugs.webkit.org/attachment.cgi?id=381555
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381555&action=review

>>> Source/WebCore/dom/KeyboardEvent.cpp:93
>>> +#endif
>> 
>> What harm would it cause to compile this on non-Cocoa platforms?
> 
> Event.location == DOM_KEY_LOCATION_RIGHT for VK_APPS when I don't know where
it is on keyboards for non-Cocoa platforms. I don't have a keyboard with this
key, yet.
> 
> Longer term, need to audit if it is 100% correct to map right command to
VK_APPS. Got to boot up Windows to double check. I think I recall USB HID spec
saying it should be mapped to what corresponds to VK_RWIN.
> 
> Anyway, I didn't have a Windows setup to test so I patched ^^^ to match
VK_APPS. Probably add a FIXME before landing to explain this if you bless this
patch.

A FIXME to clarify this sounds reasonable.