[webkit-reviews] review granted: [Bug 203560] [[HasProperty]] result of Proxy in prototype chain is ignored : [Attachment 382191] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 30 16:27:13 PDT 2019


Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 203560: [[HasProperty]] result of Proxy in prototype chain is ignored
https://bugs.webkit.org/show_bug.cgi?id=203560

Attachment 382191: Patch

https://bugs.webkit.org/attachment.cgi?id=382191&action=review




--- Comment #4 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 382191
  --> https://bugs.webkit.org/attachment.cgi?id=382191
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382191&action=review

r=me with a comment

> Source/JavaScriptCore/runtime/JSObjectInlines.h:130
> +	       return hasSlot;

Here and below, it seems like we could just return false instead?


More information about the webkit-reviews mailing list