[webkit-reviews] review denied: [Bug 202525] requestAnimationFrame and cancelAnimationFrame should be present on DedicatedWorkerGlobalScope : [Attachment 382317] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 30 14:38:50 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has denied Chris Lord <clord at igalia.com>'s
request for review:
Bug 202525: requestAnimationFrame and cancelAnimationFrame should be present on
DedicatedWorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=202525

Attachment 382317: Patch

https://bugs.webkit.org/attachment.cgi?id=382317&action=review




--- Comment #23 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 382317
  --> https://bugs.webkit.org/attachment.cgi?id=382317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382317&action=review

This should be under a runtime flag. Possibly the same one as offscreen canvas.
r- due to the lack of the runtime flag.

> Source/WebCore/workers/WorkerAnimationController.h:63
> +	   return "WorkerAnimationController";

Define this in C++.


More information about the webkit-reviews mailing list