[webkit-reviews] review granted: [Bug 203601] Opacity should always serialize as a number : [Attachment 382284] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 30 00:32:39 PDT 2019


Dirk Schulze <krit at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 203601: Opacity should always serialize as a number
https://bugs.webkit.org/show_bug.cgi?id=203601

Attachment 382284: Patch

https://bugs.webkit.org/attachment.cgi?id=382284&action=review




--- Comment #5 from Dirk Schulze <krit at webkit.org> ---
Comment on attachment 382284
  --> https://bugs.webkit.org/attachment.cgi?id=382284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382284&action=review

The change looks good to me though I have no official reviewer status at the
moment.

> Source/WebCore/css/StyleProperties.cpp:128
> +	   case CSSPropertyOpacity:

Consider adding the SVG -opacity properties: fill, stroke, stop, flood. They
behave just like opacity.


More information about the webkit-reviews mailing list